[lworld] RFR: 8263568: [lworld] Fix residual reference to 'value' [v2]

Srikanth Adayapalam sadayapalam at openjdk.java.net
Wed Mar 24 06:18:55 UTC 2021


On Tue, 23 Mar 2021 11:21:12 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> javap tool is still outputting primitive type class modifiers as `value` class, it looks like we should tweak this.
>> 
>> (Actually, I'm wondering what's the meaning of 'native' for fields that annotated with ACC_PRIMITIVE in flagToModifier? Should we remove it and change the `case 0x100` to `case ACC_PRIMITIVE` so that IDE will help us find all references if we want to do some code refactor in the future?)
>> 
>> 
>> Thanks,
>> Yang
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix test; add more comment

Changes look good. Thanks!

-------------

Marked as reviewed by sadayapalam (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/368



More information about the valhalla-dev mailing list