[lworld] RFR: 8276538: [lworld] [AArch64] LIR_Assembler::emit_profile_inline_type temporary register conflict

Frederic Parain fparain at openjdk.java.net
Fri Nov 5 16:40:22 UTC 2021


On Thu, 4 Nov 2021 08:35:55 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> LIR_Assembler::as_Address() may use rscratch1 as a temporary register
> for the address offset if it's too large to fit in an immediate, but
> rscratch1 is also used at the same time to hold the updated MDO value.
> See the discussion on JDK-8276108.

Marked as reviewed by fparain (Committer).

This was a false alarm.
I've re-tested your patch on top of the 8276108 patch, using fresh repos this time, and got no failure.
I probably managed to corrupt my repos somehow yesterday.
Sorry for the disturbance.
The patch looks good to me.

Fred

-------------

PR: https://git.openjdk.java.net/valhalla/pull/577



More information about the valhalla-dev mailing list