[lworld] RFR: 8275195: [lworld] Revisit use of TypePtr::meet_aryptr() after merge

Roland Westrelin roland at openjdk.java.net
Wed Oct 13 07:37:27 UTC 2021


I tried to move the logic that I added to TypeAryKlassPtr into
meet_aryptr() where it's shared between TypeAryPtr and
TypeAryKlassPtr. When running tests, I ran into a failure that I fixed
by making the element klass of an array of nullable inline types
to be non constant similar to this logic:

    // Even if MyValue is exact, [LMyValue is not exact due to [QMyValue <: [LMyValue.
    bool xk = etype->klass_is_exact() && (!etype->is_inlinetypeptr() || null_free);

in TypeOopPtr::make_from_klass_common().

Actually, shouldn't the element type be non exact in the TypeAryPtr
case too?

-------------

Commit messages:
 - fix

Changes: https://git.openjdk.java.net/valhalla/pull/560/files
 Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=560&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8275195
  Stats: 51 lines in 3 files changed: 16 ins; 11 del; 24 mod
  Patch: https://git.openjdk.java.net/valhalla/pull/560.diff
  Fetch: git fetch https://git.openjdk.java.net/valhalla pull/560/head:pull/560

PR: https://git.openjdk.java.net/valhalla/pull/560



More information about the valhalla-dev mailing list