[lworld] RFR: 8275195: [lworld] Revisit use of TypePtr::meet_aryptr() after merge

Roland Westrelin roland at openjdk.java.net
Wed Oct 13 13:52:07 UTC 2021


On Wed, 13 Oct 2021 13:09:25 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> > Actually, shouldn't the element type be non exact in the TypeAryPtr case too?
> 
> Yes, I think so.

Do you want me to take care of it in this change?

> Just noticed this code you added previously in `TypeAryKlassPtr::make`:
> 
> ```
>     // An object array can't be flat or null-free if the klass is exact
>     not_flat = true;
>     if (!null_free) {
>       not_null_free = true;
>     }
> ```
> 
> How can it happen that `null_free` is true?

Right above:


bool null_free = k->is_array_klass() && k->as_array_klass()->is_elem_null_free();

is that not correct?

-------------

PR: https://git.openjdk.java.net/valhalla/pull/560



More information about the valhalla-dev mailing list