[lworld] RFR: 8275195: [lworld] Revisit use of TypePtr::meet_aryptr() after merge [v2]
Roland Westrelin
roland at openjdk.java.net
Mon Oct 18 09:15:46 UTC 2021
> I tried to move the logic that I added to TypeAryKlassPtr into
> meet_aryptr() where it's shared between TypeAryPtr and
> TypeAryKlassPtr. When running tests, I ran into a failure that I fixed
> by making the element klass of an array of nullable inline types
> to be non constant similar to this logic:
>
> // Even if MyValue is exact, [LMyValue is not exact due to [QMyValue <: [LMyValue.
> bool xk = etype->klass_is_exact() && (!etype->is_inlinetypeptr() || null_free);
>
> in TypeOopPtr::make_from_klass_common().
>
> Actually, shouldn't the element type be non exact in the TypeAryPtr
> case too?
Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
- review
- Merge branch 'lworld' into HEAD
- fix
-------------
Changes:
- all: https://git.openjdk.java.net/valhalla/pull/560/files
- new: https://git.openjdk.java.net/valhalla/pull/560/files/9f1ba5de..f760dcf2
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=valhalla&pr=560&range=01
- incr: https://webrevs.openjdk.java.net/?repo=valhalla&pr=560&range=00-01
Stats: 729 lines in 37 files changed: 391 ins; 202 del; 136 mod
Patch: https://git.openjdk.java.net/valhalla/pull/560.diff
Fetch: git fetch https://git.openjdk.java.net/valhalla pull/560/head:pull/560
PR: https://git.openjdk.java.net/valhalla/pull/560
More information about the valhalla-dev
mailing list