[lworld] Integrated: 8275195: [lworld] Revisit use of TypePtr::meet_aryptr() after merge

Roland Westrelin roland at openjdk.java.net
Mon Oct 18 11:11:14 UTC 2021


On Wed, 13 Oct 2021 07:30:38 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> I tried to move the logic that I added to TypeAryKlassPtr into
> meet_aryptr() where it's shared between TypeAryPtr and
> TypeAryKlassPtr. When running tests, I ran into a failure that I fixed
> by making the element klass of an array of nullable inline types
> to be non constant similar to this logic:
> 
>     // Even if MyValue is exact, [LMyValue is not exact due to [QMyValue <: [LMyValue.
>     bool xk = etype->klass_is_exact() && (!etype->is_inlinetypeptr() || null_free);
> 
> in TypeOopPtr::make_from_klass_common().
> 
> Actually, shouldn't the element type be non exact in the TypeAryPtr
> case too?

This pull request has now been integrated.

Changeset: 31bbb950
Author:    Roland Westrelin <roland at openjdk.org>
URL:       https://git.openjdk.java.net/valhalla/commit/31bbb950e3a9084d21e7abbbadf0089f8df2ed8b
Stats:     81 lines in 3 files changed: 25 ins; 16 del; 40 mod

8275195: [lworld] Revisit use of TypePtr::meet_aryptr() after merge

Reviewed-by: thartmann

-------------

PR: https://git.openjdk.java.net/valhalla/pull/560



More information about the valhalla-dev mailing list