[lworld] RFR: 8275606: [lworld] ClassInitializationFailuresTest triggers assert with -XX:-UseTLAB
David Simms
dsimms at openjdk.java.net
Thu Oct 28 08:29:24 UTC 2021
On Wed, 27 Oct 2021 16:19:03 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> Please review those small changes fixing the handling of values with a class that failed to initialized properly.
> Changes in the test file are only code formatting.
> Tested with Mach5, tiers 1 to 3.
>
> Thank you,
>
> Fred
So at first glance I didn't understand why removing the klass initialized check from `InlineKlass::read_inlined_field()` was okay until I realized, well that method handles an "instance", and `defaultvalue` has the required check. But the fix specifically handles static fields, which `withfield` now has the check added (where there was previously a hole).
Unless my comment above is incorrect and we have further problems (no don't think so): Looks good.
-------------
Marked as reviewed by dsimms (Committer).
PR: https://git.openjdk.java.net/valhalla/pull/574
More information about the valhalla-dev
mailing list