[lworld] RFR: 8273360: [lworld] Invoking a reflection-generated constructor for primitive class gives InstantiationError [v2]

Mandy Chung mchung at openjdk.java.net
Thu Sep 23 17:06:09 UTC 2021


On Thu, 23 Sep 2021 07:30:42 GMT, Jesper Steen Møller <jespersm at openjdk.org> wrote:

>> Update constructor accessor code generation to invoke static factory method.
>
> Jesper Steen Møller has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix review issues

Looks good.  You can integrate once you update the `StaticFactoryTest.java`.

test/jdk/valhalla/valuetypes/StaticFactoryTest.java line 29:

> 27:  * @bug 8273360
> 28:  * @summary Test reflection of constructors for primitive classes
> 29:  * @run testng/othervm -Dsun.reflect.noInflation=true StaticFactoryTest

Suggestion:

 * @run testng/othervm StaticFactoryTest
 * @run testng/othervm -Dsun.reflect.noInflation=true StaticFactoryTest


This will exercise both code paths (with and without the spinned class).

-------------

Marked as reviewed by mchung (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/546


More information about the valhalla-dev mailing list