[lworld] RFR: 8281116: [lworld] Adding Preload attribute support [v2]
Frederic Parain
fparain at openjdk.java.net
Wed Feb 2 15:58:23 UTC 2022
On Wed, 2 Feb 2022 14:22:47 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Frederic Parain has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixes to address Harold's comments
>
> src/hotspot/share/classfile/classFileParser.cpp line 5951:
>
>> 5949: _record_components(NULL),
>> 5950: _temp_local_interfaces(NULL),
>> 5951: _local_interfaces(NULL),
>
> Do you need to free _preload_classes in ClassFileParser::~ClassFileParser() and set _preload_classes to NULL in ClassFileParser::clear_class_metadata(), also, assert that it is NULL in ClassFileParser::fill_instance_klass() ?
Fixed
> test/hotspot/jtreg/runtime/valhalla/inlinetypes/ValuePreloadTest.java line 61:
>
>> 59: checkFor(pb, "[warning][class,preload] Preloading of class PreloadValue1 during linking of class ValuePreloadClient1 (Preload attribute) failed");
>> 60: }
>> 61: }
>
> The test looks good but have multipe 2022's in the copyright:
> * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights reserved.
Fixed
-------------
PR: https://git.openjdk.java.net/valhalla/pull/623
More information about the valhalla-dev
mailing list