[lworld] RFR: 8281380: [lworld] Rename T_INLINE_TYPE to T_PRIMITIVE_OBJECT
Harold Seigel
hseigel at openjdk.java.net
Tue Feb 8 16:18:25 UTC 2022
On Tue, 8 Feb 2022 15:51:34 GMT, Frederic Parain <fparain at openjdk.org> wrote:
> Please review this renaming patch, changing T_INLINE_TYPE to T_PRIMITIVE_OBJECT in order to prevent the confusion between the InlineKlass concept, which is used to represent both value classes and primitive classes, and the BasicType that represents only primitive classes.
>
> Remaining occurrences of the "INLINE_TYPE" string are located in a JDI test, which could be fixed later, and in the verifier code, which might need to be revisited to check the way value classes/primitive classes are handled.
>
> Tested with Mach5, tier1 to ensure build is working on all platforms.
>
> Thank you,
>
> Fred
Changes look good! I wonder if src/java.base/share/native/libverify/check_code.c needs to worry about T_PRIMITVE_OBJECT's. It should only see old classfiles.
-------------
Marked as reviewed by hseigel (Committer).
PR: https://git.openjdk.java.net/valhalla/pull/638
More information about the valhalla-dev
mailing list