[lworld] RFR: 8281763: Support Valhalla class file features in asmtools [v2]

Leonid Kuskov lkuskov at openjdk.java.net
Wed Feb 16 02:56:25 UTC 2022


On Tue, 15 Feb 2022 23:22:43 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

>> Modifying the Valhalla repo's fork of asmtools to implement Valhalla class file features:
>> 
>> - ACC_VALUE, ACC_PERMITS_VALUE, and ACC_PRIMITIVE 
>> - Preload attribute 
>> - aconst_init & withfield instructions 
>> - Unnamed factory methods 
>> - Q descriptors
>> 
>> Mainly relevant to the `jasm` tool, but there are also some interactions with `jdis` and `jdec`. No impact on `jcod`.
>
> Dan Smith has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
> 
>  - Merge branch 'asmtools' into asmtools-valhalla
>  - Merge branch 'lworld' into asmtools
>  - 8281880: AsmTools driver uses wrong implementation classes
>  - Merge branch 'asmtools' into asmtools-valhalla
>  - Merge branch 'lworld' into asmtools
>  - Modified asmtools files
>  - AsmTools updates for Valhalla features
>  - Merge branch 'lworld' into asmtools
>  - Fix trailing whitespace
>  - Added usage comment
>  - ... and 3 more: https://git.openjdk.java.net/valhalla/compare/2c8ecdb0...634c132f

Looks good to me.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/647


More information about the valhalla-dev mailing list