[lworld] RFR: 8281283: Remove usages of __WithField in runtime tests
Dan Smith
dlsmith at openjdk.java.net
Thu Feb 17 01:03:36 UTC 2022
Modifying Valhalla runtime tests to no longer use `__WithField` as a macro for the `withfield` instruction. Most uses can be replaced with standard constructor compilation via javac. The remaining uses are rewritten in jasm.
Summary of changes:
- Remove all uses of `-XDallowWithFieldOperator`
- Replace various `make` and `create` factory methods for primitive classes with constructors
- Bug fixes for `JumboInline` that were exposed by this change
- Rewrote `TestFieldNullability` to use jasm
- Rewrote `VWithFieldTest` to use jasm, renamed `WithFieldTest`
- Rewrote `WithFieldAccessorTest` to use jasm, made more comprehensive
- Deleted `WithFieldNoAccessTest`, made redundant by `WithFieldAccessorTest` changes
- Minor tweaks to `TestFieldTypeMismatch` for consistent jasm usage
- Cleanup of some debugging output in `asmtools.JtregDriver`
-------------
Commit messages:
- Fix whitespace
- WithFieldNoAccessTest is superceded by revised WithFieldAccessTest
- withfield tests using jasm
- Fix up jasm tests
- Fix whitespace
- Merge branch 'lworld' into 8281283
- Convert TestFieldNullability to jasm
- Convert __Withfield usages in factories to constructors
Changes: https://git.openjdk.java.net/valhalla/pull/653/files
Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=653&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8281283
Stats: 2016 lines in 38 files changed: 703 ins; 1105 del; 208 mod
Patch: https://git.openjdk.java.net/valhalla/pull/653.diff
Fetch: git fetch https://git.openjdk.java.net/valhalla pull/653/head:pull/653
PR: https://git.openjdk.java.net/valhalla/pull/653
More information about the valhalla-dev
mailing list