[lworld] RFR: 8281283: Remove usages of __WithField in runtime tests

[David Simms]

On Thu, 17 Feb 2022 00:56:50 GMT, Dan Smith <dlsmith at openjdk.org> wrote:

> Modifying Valhalla runtime tests to no longer use `__WithField` as a macro for the `withfield` instruction. Most uses can be replaced with standard constructor compilation via javac. The remaining uses are rewritten in jasm.
> 
> Summary of changes:
> 
> - Remove all uses of `-XDallowWithFieldOperator`
> - Replace various `make` and `create` factory methods for primitive classes with constructors
> - Bug fixes for `JumboInline` that were exposed by this change
> - Rewrote `TestFieldNullability` to use jasm
> - Rewrote `VWithFieldTest` to use jasm, renamed `WithFieldTest`
> - Rewrote `WithFieldAccessorTest` to use jasm, made more comprehensive
> - Deleted `WithFieldNoAccessTest`, made redundant by `WithFieldAccessorTest` changes
> - Minor tweaks to `TestFieldTypeMismatch` for consistent jasm usage
> - Cleanup of some debugging output in `asmtools.JtregDriver`

For my part the Hotspot Runtime tests look good. Thanks for cleaning some of the old cruft where appropriate.

-------------

Marked as reviewed by dsimms (Committer).

PR: https://git.openjdk.java.net/valhalla/pull/653