[lworld] RFR: 8281323: [lworld] Unnecessary entries in Preload attribute

[Aggelos Biboudis]

On Tue, 22 Feb 2022 09:29:37 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Reimplement generation of Preload attribute decoupling it from InnerClasses attribute generation to minimize/eliminate needless entries from the Preload list

Looks good!

src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/PoolWriter.java line 260:

> 258:         }
> 259:         c.complete();
> 260:         if (c.isValueClass() && !c.isPrimitiveClass()) {

This is fully covered by `requiresPreload` in `Type`. Actually more strict, because of the `if (this.isReferenceProjection()) return true;` condition in the previous method. Is my understanding correct?

-------------

Marked as reviewed by biboudis at github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/valhalla/pull/656