[lworld] RFR: 8280164: [lworld] Generate Preload attribute to enumerate value classes encountered

Srikanth Adayapalam sadayapalam at openjdk.java.net
Wed Jan 19 14:12:07 UTC 2022


On Wed, 19 Jan 2022 13:24:31 GMT, Aggelos Biboudis <duke at openjdk.java.net> wrote:

>> Modelled after InnerClasses attribute generation, we may be generating more information than necessary/useful but this is initial cut
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/PoolWriter.java line 98:
> 
>> 96:     LinkedHashSet<ClassSymbol> innerClasses = new LinkedHashSet<>();
>> 97: 
>> 98:     HashSet<ClassSymbol> valueClasses = new HashSet<>();
> 
> nitpicking:`Set` instead of `HashSet` for the type definition? (hm, the interface is used below in line 101 but not in the line 96 above)

Done. I started out that way and seeing the line above decided to align, but always do the right thing is a good motto :)

-------------

PR: https://git.openjdk.java.net/valhalla/pull/605



More information about the valhalla-dev mailing list