[lworld] RFR: 8280382: [lworld] JCWithField AST node support should evolve to work with value classes

[Aggelos Biboudis]

On Fri, 28 Jan 2022 09:41:59 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

>> You are right. The idea behind it was that I was getting a null reference exception on the subtype check. `t.referenceProjection()` was returning `null`  and it was blowing up on the `t.equalsIgnoreMetadata(s)`. The triggering code was something like the following (so the reference projection of `o`  was `null`).
>> 
>> 
>> value static final class V {}
>> 
>> Object o = V.default;
>> 
>> 
>> What do you think?
>
>> You are right. The idea behind it was that I was getting a null reference exception on the subtype check. `t.referenceProjection()` was returning `null` and it was blowing up on the `t.equalsIgnoreMetadata(s)`. The triggering code was something like the following (so the reference projection of `o` was `null`).
>> 
>> ```
>> value static final class V {}
>> 
>> Object o = V.default;
>> ```
>> 
>> What do you think?
> 
> If this probem is still persisting, I suggest we raise a separate ticket for it. I don't know what is going on there, but can take a look and share observations on a separate task basis.

It was only introduced only after changing the lines 608 and 609 above, so it feels related to this change:

> https://github.com/openjdk/valhalla/pull/621/files/e0f302f20eacdbb796d03240b5b727ce053ed451#diff-244efd7111106b403c989b25a6d0c719dcb15d44892320cfdc6056a418defb21L608-L609

-------------

PR: https://git.openjdk.java.net/valhalla/pull/621