RFR: addressing several issues in the implementation of universal tvars [v6]

[Vicente Romero]

On Tue, 7 Jun 2022 14:37:51 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   adding structural type comparator to detect unchecked conversions
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1179:
> 
>> 1177:                     case BOT: case NONE:
>> 1178:                         return t.hasTag(s.getTag());
>> 1179:                     case WILDCARD: //we shouldn't be here - avoids crash (see 7034495)
> 
> I do not see a visitor method for wildcards, but I think you need one, as you might get to wildcards recursively, because of `visitClassType`

I think we should be covered here as visitors: `StructuralTypeComparator` and `TypeArgStructComparator` are interdependent, so I think we should be fine there, unless I'm missing something

-------------

PR: https://git.openjdk.java.net/valhalla/pull/684