RFR: addressing several issues in the implementation of universal tvars [v8]

Vicente Romero vromero at openjdk.java.net
Wed Jun 8 17:07:00 UTC 2022


On Wed, 8 Jun 2022 14:57:25 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1378:
>> 
>>> 1376:         SubtypingRelation isSubtypeRelation = new SubtypingRelation();
>>> 1377:         class SubtypingRelation extends TypeRelation {
>>> 1378:             SubtypingRelationKind param;
>> 
>> What is this needed for? We should get into a position where subtyping is "just" subtyping, no need for having some kind of mode flag - unless I'm misunderstanding something?
>
> yep I will tackle that now, if I recall correctly I tried to removed it but there where other changes in areas a bit distant from the visitors that's why I didn't go for it in a first step

sorry it was a simple change I thought it would be a greater one, just uploaded a new version that removes this `param` and related code from `isSubtype`

-------------

PR: https://git.openjdk.java.net/valhalla/pull/684



More information about the valhalla-dev mailing list