[lworld] RFR: 8283777: [lworld] TestArrayCopyAsLoadsStores.java triggers assert after merging jdk-19+15

Tobias Hartmann thartmann at openjdk.java.net
Thu Jun 9 14:33:47 UTC 2022


We hit a dominance assert because `maybe_cast_profiled_obj` replaces `original` in the map while there can still be a bailout afterwards. This code is not Valhalla specific but was moved up to before the uncommon trap long ago with https://github.com/openjdk/valhalla/commit/09f099cab74c483c4aee3e927f2bc3c41ad784c9. I don't think that's required anymore, so this change simply restores the mainline version.

Thanks,
Tobias

-------------

Commit messages:
 - 8283777: [lworld] TestArrayCopyAsLoadsStores.java triggers assert after merging jdk-19+15

Changes: https://git.openjdk.org/valhalla/pull/710/files
 Webrev: https://webrevs.openjdk.java.net/?repo=valhalla&pr=710&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8283777
  Stats: 46 lines in 2 files changed: 20 ins; 24 del; 2 mod
  Patch: https://git.openjdk.org/valhalla/pull/710.diff
  Fetch: git fetch https://git.openjdk.org/valhalla pull/710/head:pull/710

PR: https://git.openjdk.org/valhalla/pull/710



More information about the valhalla-dev mailing list