RFR: addressing review comments

[Vicente Romero]

On Wed, 2 Mar 2022 20:56:38 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> Fixing a compiler crash plus other review comments from Maurizio

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 1692:

> 1690:                     // warnStack.head is != null if we are checking for an assignment, in other cases we should be strict
> 1691:                     // the order in the condition below matters
> 1692:                     if (warnStack.head != null && allowUniversalTVars && !result) {

using the emptiness of the warnStack as the way to know if we are dealing with an assignment or not seems a bit fragile, another option could be to pass down a boolean all the way down from all invocations, what do you think?

-------------

PR: https://git.openjdk.java.net/valhalla/pull/663