[lworld] RFR: 8283573: [lworld] Make Object an abstract class

[Frederic Parain]

On Fri, 25 Mar 2022 13:44:01 GMT, David Simms <dsimms at openjdk.org> wrote:

>> 8283573: [lworld] Make Object an abstract class
>
> src/hotspot/share/c1/c1_GraphBuilder.cpp line 2541:
> 
>> 2539:   assert(klass->is_instance_klass(), "must be an instance klass");
>> 2540:   ciKlass* ik = klass;
>> 2541:   if (ik == compilation()->env()->Object_klass() && compilation()->env()->Object_klass()->is_abstract()) {
> 
> Does adding if EnableValhalla as the first condition, or a "// Valhalla" comment, make this clearer ? There are a few places in the change set with the same review comment, but I won't repeat.

I'll add the if(EnableValhalla) condition.

-------------

PR: https://git.openjdk.java.net/valhalla/pull/602