[lworld] RFR: 8286491: Withdraw ValueObject and IdentityObject and introduce value and identity class modifiers

[Srikanth Adayapalam]

On Tue, 10 May 2022 14:28:16 GMT, Srikanth Adayapalam <sadayapalam at openjdk.org> wrote:

> Changes to javac, hotspot runtime, core libs and asmtools sources and tests

This PR implements the following:

    - Withdraw the top interface types ValueObject and IdentityObject
    - Add support for identity and value contextual keyword modifiers for flagging value'ness/identityness of a class/interface.
    - Redefine ACC_VALUE to be 0x40

Notes for hotspot, core-libs and other non-langtools changes reviewers:

Changes necessary to rip out PERMITS_VALUE flag bit are not included - I have simply redefined the value of the flag bit to "get it out of the way"

This change set is failing a few tier 1,2,3 tests - I will attach the list of failing tests. If you will provide me with fixes for these and also any additional rectifications/amendments/changes you see fit, I am happy to include them - Thanks!

Tier1 Failing Tests:

Hotspot/runtime:

runtime/valhalla/inlinetypes/classfileparser/ACC_CFETest.java
runtime/valhalla/inlinetypes/identityObject/TestIdentityObject.java
runtime/valhalla/inlinetypes/primitiveObject/TestPrimitiveObject.java
runtime/valhalla/inlinetypes/testSupers/TestSuperClasses.java
runtime/valhalla/inlinetypes/verifier/VerifierInlineTypes.java
runtime/valhalla/inlinetypes/withfieldTests/RunWithfieldTests.java
serviceability/dcmd/vm/ClassHierarchyTest.java

Langtools:
tools/javac/ClassFileModifiers/ClassModifiers.java
tools/javac/SynchronizedClass.java
tools/javac/classfiles/attributes/innerclasses/InnerAnnotationsInInnerClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerAnnotationsInInnerEnumTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInAnonymousClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerAnnotationTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerEnumTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerInterfaceTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesInLocalClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerClassesTest.java
tools/javac/classfiles/attributes/innerclasses/InnerEnumInInnerAnnotationTest.java
tools/javac/classfiles/attributes/innerclasses/InnerEnumInInnerEnumTest.java
tools/javac/classfiles/attributes/innerclasses/InnerEnumInInnerInterfaceTest.java
tools/javac/classfiles/attributes/innerclasses/InnerEnumsInInnerClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerInterfacesInInnerClassTest.java
tools/javac/classfiles/attributes/innerclasses/InnerInterfacesInInnerEnumTest.java
tools/javac/diags/CheckExamples.java
tools/javac/platform/createsymbols/CreateSymbolsTest.java
tools/javac/processing/model/completionfailure/NoAbortForBadClassFile.java
tools/javap/TestSuperclass.java

-------------

PR: https://git.openjdk.java.net/valhalla/pull/688