RFR: addressing several issues in the implementation of universal tvars [v4]
Vicente Romero
vromero at openjdk.java.net
Fri May 20 21:22:18 UTC 2022
On Fri, 20 May 2022 16:49:36 GMT, ExE Boss <duke at openjdk.java.net> wrote:
>> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
>>
>> removing commented code
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 680:
>
>> 678: isSubtype(t, boxedTypeOrType(s)) :
>> 679: isSubtype(boxedTypeOrType(t), s);
>> 680: return result ? IsConvertibleResult.CONVERTIBLE : IsConvertibleResult.NOT_CONVERTIBLE;
>
> Suggestion:
>
> return IsConvertibleResult.of(tUndet ?
> isSubtype(t, boxedTypeOrType(s)) :
> isSubtype(boxedTypeOrType(t), s));
yep, could be thanks for the suggestion
-------------
PR: https://git.openjdk.java.net/valhalla/pull/684
More information about the valhalla-dev
mailing list