[lworld] RFR: 8288135: [lworld] Implement HotSpot flag -XX:+EnablePrimitiveClasses [v11]

[David Simms]

On Tue, 4 Oct 2022 18:40:20 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> David Simms has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments applied
>
> test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestMethodHandleAccess.java.template line 29:
> 
>> 27:  * @test
>> 28:  * @compile -XDenablePrimitiveClasses Point.java Value.java VarHandleTestMethodHandleAccess$Type$.java
>> 29:  * @run testng/othervm -XX:+EnableValhalla -XX:+EnablePrimitiveClasses -Diters=2000 VarHandleTestMethodHandleAccess$Type$
> 
> X-VarHandleTestXXX.java.template changes look wrong and maybe merge issue.  These files were updated recently.
> 
> For VarHandles tests, you only need to modify X-VarHandleTestXXX.java.template files to add `-XX:+EnablePrimitiveClasses` flag and then run `test/jdk/java/lang/invoke/VarHandles/generate-vh-tests.sh` that will regenerate the `test/jdk/java/lang/invoke/VarHandles/VarHandle*` tests.

So the problem here is SPP. AFAIK, SPP doesn't support boolean expressions, and `X-VarHandleTestMethodHandleAccess.java.template` refers to both `Value` and `Point `.

I'm sure there are reasons why the build systems' C preprocessor isn't being used, at build time, and we remove generated source from the repository, but that feels out of scope for this change.

-------------

PR: https://git.openjdk.org/valhalla/pull/727