[lworld] RFR: 8288135: [lworld] Implement HotSpot flag -XX:+EnablePrimitiveClasses [v12]

Mandy Chung mchung at openjdk.org
Wed Oct 5 18:55:41 UTC 2022


On Wed, 5 Oct 2022 06:28:47 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Runtime component of -XX:+EnablePrimitiveClasses switch
>
> David Simms has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
> 
>  - Merge branch 'lworld' into 8288135
>  - Review comments applied
>  - Merge branch 'lworld' into 8288135
>  - Extra assertion info for tracking spurious issue
>  - supports_inline_types() refers to classfile and is separate from Enable flags
>  - Further testing explicity using flags
>  - Disable EnablePrimitiveClasses by default
>  - Explictly flag more tests
>  - Merge branch 'lworld' into 8288135
>  - jdk_valhalla tests
>  - ... and 14 more: https://git.openjdk.org/valhalla/compare/ee15e2d9...92e5253d

test/jdk/java/lang/invoke/VarHandles/X-VarHandleTestMethodType.java.template line 29:

> 27:  * @test
> 28:  * @bug 8156486
> 29: #if[Point]

This change intends to make `@compile....` to be conditional.   So it can simply do:

Suggestion:

#if[Point]
     * @compile -XDenablePrimitiveClasses Point.java Value.java VarHandleTestMethodType$Type$.java
#end[Point]


No need to duplicate all `@run` statements.

test/jdk/valhalla/valuetypes/QTypeDescriptorTest.java line 30:

> 28:  * @compile -XDenablePrimitiveClasses QTypeDescriptorTest.java
> 29:  * @run testng/othervm -XX:+EnableValhalla -XX:+EnablePrimitiveClasses QTypeDescriptorTest
> 30:  * @compile -XDenablePrimitiveClasses QTypeDescriptorTest.java

This `@compile` seems duplicated.   Since you are on this file, do u mind taking it out?

-------------

PR: https://git.openjdk.org/valhalla/pull/727



More information about the valhalla-dev mailing list