[lworld] RFR: 8294797: [lworld] update javadoc to remove references to primitive classes [v2]

Mandy Chung mchung at openjdk.org
Thu Oct 6 17:38:34 UTC 2022


On Thu, 6 Oct 2022 16:34:13 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Mandy Chung has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - update @throws for references
>>  - Merge branch 'lworld' of https://github.com/openjdk/valhalla into javadoc-fix
>>  - 8294797: [lworld] update javadoc to remove references to primitive classes
>
> src/java.base/share/classes/java/lang/ref/PhantomReference.java line 94:
> 
>> 92:      * @param q the queue with which the reference is to be registered,
>> 93:      *          or {@code null} if registration is not required
>> 94:      * @throws IdentityException if the referent is an instance of an
> 
> Instead this should refer to isIdentity(), the implementation uses Objects.isIdentityObject(referent).
> Perhaps:
> @throws IdentityException if the referent is not an {@link Objects#isIdentityObject(Object o) identity object}.
> 
> The same applied to SoftReference and WeakReference. (below)

updated.

-------------

PR: https://git.openjdk.org/valhalla/pull/776



More information about the valhalla-dev mailing list