[lworld] RFR: 8295234: [lworld] inner class of older classfile versions is not recognized as identity class

Frederic Parain fparain at openjdk.org
Fri Oct 14 17:32:27 UTC 2022


On Fri, 14 Oct 2022 00:10:57 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> The modifiers of an inner class uses the access flags in the `InnerClasses`  attribute.   An inner class with an older class file version does not have `ACC_IDENTITY` flag set.   Instead of having `Class::isIdentity`  to depend on `getModifiers()`, this PR proposes to make `Class::isIdentity` a native method implemented by the VM. In addition, `Class::isIdentity` can be made as intrinsics.
> 
> I leave `Class::isValue` as is.   A value class must have `ACC_VALUE` flag set.   `Class::getModifiers` is already intrinsified.   We can revisit this in the future when there is a need to make it as a native VM method.

Looks good to me.

Fred

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.org/valhalla/pull/794



More information about the valhalla-dev mailing list