[lworld] RFR: 8247569: [lworld] Align with spec for <vnew> methods [v3]

David Simms dsimms at openjdk.org
Wed Oct 19 10:34:50 UTC 2022


On Tue, 18 Oct 2022 17:34:15 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> David Simms has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/valhalla/valuetypes/StaticFactoryMethodHandleTest.java
>>   
>>   Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>
> src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java line 95:
> 
>> 93:         boolean isStaticFactory = declaringClass.isValue();
>> 94:         return (ConstructorAccessor) generate(declaringClass,
>> 95:                                               isStaticFactory ? "<vnew>" : "<init>",
> 
> Core reflection does not use this method accessor generator by default.   I don't expect this change is needed.  Are you seeing any test failure without this change and other relevant change in jdk.internal.reflect?

It's gone, JDK-8281295 removed its use

-------------

PR: https://git.openjdk.org/valhalla/pull/788



More information about the valhalla-dev mailing list