[lworld] RFR: 8247569: [lworld] Align with spec for <vnew> methods [v3]

[Frederic Parain]

On Wed, 19 Oct 2022 10:34:48 GMT, David Simms <dsimms at openjdk.org> wrote:

>> Merged javac and VM work together, includes VM support (JDK-8294224)
>
> David Simms has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test/jdk/valhalla/valuetypes/StaticFactoryMethodHandleTest.java
>   
>   Co-authored-by: Mandy Chung <mandy.chung at oracle.com>

VM changes look good to me (with one comment on is_object_constructor() and is_static_vnew_factory() methods).

src/hotspot/share/oops/method.cpp line 945:

> 943: // A method named <init>, if non-static, is a classic object constructor.
> 944: bool Method::is_object_constructor() const {
> 945:   return name() == vmSymbols::object_initializer_name() && !is_static();

Do we still need to check that the method is not static?
Now that constructors and static factories have different names, the check of the static flag looks superfluous (applies to the method below as well, and to the comments above the method declaration).

-------------

Marked as reviewed by fparain (Committer).

PR: https://git.openjdk.org/valhalla/pull/788