[lworld] RFR: 8293448: [lworld] ClassAccessFlagsRawTest fail

Roger Riggs rriggs at openjdk.org
Tue Sep 6 22:11:00 UTC 2022


On Tue, 6 Sep 2022 21:08:26 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Fix test of ClassAccessFlagsRawTest to verify ACC_IDENTITY when it is inserted based on the class file version being read.
> ACC_IDENTITY is seen for all concrete classes and arrays of same.

The test was originally written for the main line where only the ACC_SUPER bit is defined.  
The test was intended to show that ACC_SUPER appeared in the raw access flags when it was in the class file (.jcod).
With Valhalla, the ACC_SUPER bit is re-assigned to be ACC_IDENTITY and ACC_SUPER is no longer defined in class files.
The ACC_IDENTITY bit is computed and returned from Class.getModifiers and the new `Class.getClassAccessFlagsRaw()` method depending on the class file version number and inserted into the modifiers to meet the spec.

This is an awkward but temporary fix until --enable-preview is implemented and Valhalla class files have a different minor version than the main-line.

-------------

PR: https://git.openjdk.org/valhalla/pull/744



More information about the valhalla-dev mailing list