[lworld] RFR: 8287692: Move Class primitive APIs to jdk.internal.value.PrimitiveClass
Mandy Chung
mchung at openjdk.org
Fri Sep 9 22:31:41 UTC 2022
On Fri, 9 Sep 2022 17:06:30 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> Move Class primitive APIs to jdk.internal.value.PrimitiveClass.
>
> Update hotspot tests to use PrimitiveClass instead of Class.xxx methods.
> Add imports of jdk.internal.value.PrimitiveClass
> Add --add-exports java.base/jdk.internal.value=ALL-UNNAMED
test/jdk/java/lang/invoke/condy/BootstrapMethodJumboArgsTest.java line 2:
> 1: /*
> 2: * Copyright (c) 2017, 2022, Oracle and/or its affiliates. All rights reserved.
is this change needed?
test/jdk/valhalla/valuetypes/ObjectMethodsViaCondy.java line 27:
> 25: * @test
> 26: * @summary Test ObjectMethods::bootstrap call via condy
> 27: * @modules java.base/jdk.internal.value:+open
Is `+open` needed? PrimitiveClass methods are all public. `+open` is needed only for deep reflection.
Same comments apply to other tests.
test/jdk/valhalla/valuetypes/ProxyTest.java line 33:
> 31: import java.util.Arrays;
> 32:
> 33:
No change in this file.
test/jdk/valhalla/valuetypes/UninitializedValueTest.java line 40:
> 38: import jdk.internal.value.PrimitiveClass;
> 39:
> 40:
extra new line
-------------
PR: https://git.openjdk.org/valhalla/pull/752
More information about the valhalla-dev
mailing list