[lworld] RFR: 8287692: Move Class primitive APIs to jdk.internal.value.PrimitiveClass [v2]

Mandy Chung mchung at openjdk.org
Mon Sep 12 18:48:04 UTC 2022


On Mon, 12 Sep 2022 15:53:52 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Move Class primitive APIs to jdk.internal.value.PrimitiveClass.
>> 
>> Update hotspot tests to use PrimitiveClass instead of Class.xxx methods.
>> Add imports of jdk.internal.value.PrimitiveClass
>> Add --add-exports java.base/jdk.internal.value=ALL-UNNAMED
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanup based on review comments.

JavaLangAccess.java has whitespace changes which I believe it's not intentional.  Please revert those whitespace change before pushing the changes.

test/hotspot/jtreg/serviceability/jvmti/Valhalla/HeapDump/HeapDump.java line 267:

> 265:         for (Field testField : fields) {
> 266:             boolean isStatic = Modifier.isStatic(testField.getModifiers());
> 267:             boolean isPrimitive = (testField.getModifiers() & 0x0800) != 0; // TBD: until the modifiers settle down

This can be replaced with `PrimitiveClass.isPrimitiveClass`

test/jdk/valhalla/valuetypes/ProxyTest.java line 33:

> 31: import java.util.Arrays;
> 32: 
> 33: 

This test should have no modification.   This extra line can be cleaned up.

-------------

Marked as reviewed by mchung (Committer).

PR: https://git.openjdk.org/valhalla/pull/752



More information about the valhalla-dev mailing list