[lworld] RFR: 8294159: automatically generated tests under test/jdk/java/lang/invoke/VarHandles/ have been modified by mistake [v3]

Mandy Chung mchung at openjdk.org
Thu Sep 22 20:03:51 UTC 2022


On Thu, 22 Sep 2022 19:58:08 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Most tests under `test/jdk/java/lang/invoke/VarHandles/` should be generated from a template, that is processed by the script `generate-vh-tests.sh` located in the same folder. Several of these tests have been modified directly instead of modifying the template. This PR is correcting this issue,
>> 
>> TIA
>
> Vicente Romero has updated the pull request incrementally with one additional commit since the last revision:
> 
>   restoring some code removed from primitive classes tests

Change in the `X-VarHandle*` template files looks good.   I assume the tests are generated by running the unchanged generate-vh-tests.sh.   It's all good.

Thanks for taking care of this.

-------------

Marked as reviewed by mchung (Committer).

PR: https://git.openjdk.org/valhalla/pull/765



More information about the valhalla-dev mailing list