[lworld+vector] RFR: 8304310: Initial compilers and runtime handling for multifield backed vectors. [v6]

Xiaohong Gong xgong at openjdk.org
Fri Apr 7 02:32:12 UTC 2023


On Fri, 7 Apr 2023 00:30:13 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> BTW, methods like `is_multifield, is_multifield_base` can be removed. `secondary_fields_count() > 1` can be used as a replacement to `is_multifield_base()`, right?
>
>> BTW, methods like `is_multifield, is_multifield_base` can be removed. `secondary_fields_count() > 1` can be used as a replacement to `is_multifield_base()`, right?
> 
> It should add value to still keep is_multifield and is_multifield_base since it allows skipping over synthetic fields (non-base) at places.

I'm sorry that I don't understand quite well. At least, `is_multifield()` is not used now. So I guess it can be removed?

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/833#discussion_r1160390363



More information about the valhalla-dev mailing list