[lworld] RFR: 8304168: [lworld] CDS tests fail with --enable-preview patched value classes [v2]

Wed Apr 19 13:07:24 UTC 2023

On Wed, 15 Mar 2023 19:29:07 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> When --enable-preview is true, the patching of some java.base classes as value classes disables CDS. 
>> Subsequently the CDS tests fail.
>> 
>> For a CDS, disable Valhalla when --enable-preview is set so java.base is not patched with value classes.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change to jdi TestScaffold

Looks reasonable to me.

Problem listing sounds good as well. This just causes lots of noise in testing in the CI so it would be nice to get a fix in soon.

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/832#pullrequestreview-1392018146
PR Comment: https://git.openjdk.org/valhalla/pull/832#issuecomment-1514701377