[lworld] RFR: 8314190: [lworld] Missing InlineTypeNode re-materialization during type sharpening.
Jatin Bhateja
jbhateja at openjdk.org
Thu Aug 17 11:17:30 UTC 2023
On Wed, 16 Aug 2023 13:37:46 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> - Currently we try to sharpen the object type to a narrower type to optimize object type comparison against a class constant.
>> - This is achieved by inserting a CheckCastPP node which casts the object type to a higher speculative type, if cast type is an inlinetype we need to rematerialize InlineTypeNode from newly casted object which was missing and is fixed by the patch.
>>
>> Kindly review.
>>
>> Tier1 regressions are clean.
>>
>> Best Regards,
>> Jatin Bhateja
>
> Thanks for fixing this, Jatin. Could you add a corresponding IR framework test?
Hi @TobiHartmann , comments addressed.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/907#issuecomment-1682098486
More information about the valhalla-dev
mailing list