[lworld] RFR: 8314190: [lworld] Missing InlineTypeNode re-materialization during type sharpening. [v2]

[Jatin Bhateja]

On Fri, 18 Aug 2023 08:21:03 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adding an IR test and review comment resolution.
>
> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestValueRematDuringTypeSharpening.java line 81:
> 
>> 79:        for (int i = 0; i < 10000; i++) {
>> 80:            res += test((i % 1000) == 1 ? new dummyValue1(i) : new dummyValue2(i));
>> 81:        }
> 
> I think you should leave warmup to the IR framework. If more iterations are needed, you can control that via the `@Warmup` annotation. And here, just do:
> 
> test(new dummyValue1(0));
> test(new dummyValue2(2));

Thanks @TobiHartmann , standalone run mode has no warmups hence there was an explicit warmup loop, changed as per your suggestion.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/907#discussion_r1298829475