[lworld] RFR: 8314190: [lworld] Missing InlineTypeNode re-materialization during type sharpening. [v3]

Tobias Hartmann thartmann at openjdk.org
Mon Aug 21 07:20:51 UTC 2023


On Fri, 18 Aug 2023 20:13:28 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> -  Currently we try to sharpen the object type to a narrower type to optimize object type comparison against a class constant.
>>  - This is achieved by inserting a CheckCastPP node which casts the object type to a higher speculative type, if cast type is an inlinetype we need to rematerialize InlineTypeNode from newly casted object which was missing and is fixed by the patch.
>> 
>> Kindly review.
>> 
>> Tier1 regressions are clean.
>> 
>> Best Regards,
>> Jatin Bhateja
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments resolutions.

Looks good to me. Thanks for fixing!

-------------

Marked as reviewed by thartmann (Committer).

PR Review: https://git.openjdk.org/valhalla/pull/907#pullrequestreview-1586349684



More information about the valhalla-dev mailing list