[lworld+vector] RFR: 8314980: [lworld+vector] consider scalarization conditions during ciMultiField creation. [v2]

Jatin Bhateja jbhateja at openjdk.org
Mon Aug 28 06:15:30 UTC 2023


On Mon, 28 Aug 2023 02:00:37 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused function declaration.
>
> src/hotspot/share/ci/ciEnv.cpp line 1782:
> 
>> 1780:   return InlineTypeNode::is_multifield_scalarized(bt, vec_length);
>> 1781: #else
>> 1782:   return false;
> 
> 1. I think it's better to implement `is_multifield_scalarized()` here, and reference it in C2 compiler. It's opposite here.
> 2. By default, it should return `true` instead of `false` if `COMPILER2` is not supported.

Agree with 2, thanks, will correct it! Idea here is that ci should leverage compiler exposed interfaces to determine scalarizability.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/918#discussion_r1306951790



More information about the valhalla-dev mailing list