[lworld+vector] RFR: Merge lworld [v2]
Xiaohong Gong
xgong at openjdk.org
Thu Aug 31 06:56:30 UTC 2023
On Wed, 30 Aug 2023 06:36:01 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> This patch merges the latest `valhalla:lworld` to
>> `valhalla:lworld+vector` branch, together with following
>> main changes:
>>
>> 1. Resolve conflicts mainly caused by the BACKOUT of
>> `VectorShuffle refactory` in jdk mainline [1].
>> 2. Fix the class id issue for `SafePointScalarMergeNode` added by [JDK-8287061](https://bugs.openjdk.java.net/browse/JDK-8287061). This causes an jvm crash
>> when building the jdk image. `lworld` branch also
>> fixes it (see [2]), but it seems the id is not correctly
>> ordered.
>>
>> [1] https://github.com/openjdk/jdk/pull/14629
>>
>> [2] https://github.com/openjdk/valhalla/blob/lworld/src/hotspot/share/opto/node.hpp#L738
>
> Xiaohong Gong has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Merge lworld
>
Unfortunately, the regressions are still there even with the AArch64 changes. One of the log is:
test Int128VectorTests.GEInt128VectorTestsMasked(int[i], int[i], mask[i % 2]): failure
java.lang.AssertionError: expected [true] but found [false]
at org.testng.Assert.fail(Assert.java:99)
at org.testng.Assert.failNotEquals(Assert.java:1037)
at org.testng.Assert.assertEqualsImpl(Assert.java:140)
at org.testng.Assert.assertEquals(Assert.java:122)
at org.testng.Assert.assertEquals(Assert.java:819)
at org.testng.Assert.assertEquals(Assert.java:829)
at Int128VectorTests.GEInt128VectorTestsMasked(Int128VectorTests.java:4176)
Anyway, this is not invoked by this merge, and I will revisit the regressions in furure.
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/921#issuecomment-1700465690
More information about the valhalla-dev
mailing list