[lworld+vector] RFR: Merge lworld [v2]

[Jatin Bhateja]

On Thu, 31 Aug 2023 06:53:52 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> Xiaohong Gong has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Merge lworld
>
>> 
> 
> Unfortunately, the regressions are still there even with the AArch64 changes. One of the log is:
> 
> test Int128VectorTests.GEInt128VectorTestsMasked(int[i], int[i], mask[i % 2]): failure
> java.lang.AssertionError: expected [true] but found [false]
>         at org.testng.Assert.fail(Assert.java:99)
>         at org.testng.Assert.failNotEquals(Assert.java:1037)
>         at org.testng.Assert.assertEqualsImpl(Assert.java:140)
>         at org.testng.Assert.assertEquals(Assert.java:122)
>         at org.testng.Assert.assertEquals(Assert.java:819)
>         at org.testng.Assert.assertEquals(Assert.java:829)
>         at Int128VectorTests.GEInt128VectorTestsMasked(Int128VectorTests.java:4176)
> 
> Anyway, this is not invoked by this merge, and I will revisit the regressions in furure.

> > Hi @XiaohongGong ,
> > I verified that validation status is intact and other failures with additional -XX:+DeoptimizeALot option are also fixed with the merge.
> > Best Regards, Jatin
> 
> Thanks for the review and testing @jatin-bhateja ! Did you see any other regressions on Vector API tests with this option? I also ran the tests with `-XX:+DeoptimizeALot`, but some regressions that I met before are still there on NEON. I remembered that some x86 specific code was changed (i.e. [d9f744f#diff-a47d36f3d2e8997bd3d2320ef348dd17b91f388d2cb6e91e9d99d66df5ccd897](https://github.com/openjdk/valhalla/commit/d9f744fe6e816a91aa7c8d5e84ce464e8a9d3921#diff-a47d36f3d2e8997bd3d2320ef348dd17b91f388d2cb6e91e9d99d66df5ccd897)), which is missing on AArch64 platform now. Seems this can also influence the result in interpreter, right? I will have a test by adding the similar code on AArch64 again.
> 
> Best Regards, Xiaohong

Yes, this can impact test failures since VectorPayload* constructors return a value object and we do not want to scalarize it, by default values are flattened using unpacking handlers.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/921#issuecomment-1700813401