[lworld] RFR: 8321039: [lworld] Substitutability code must recognize new annotations [v2]

Mandy Chung mchung at openjdk.org
Wed Dec 6 18:17:42 UTC 2023


On Wed, 6 Dec 2023 15:59:21 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comment
>
> test/jdk/valhalla/valuetypes/NullRestrictedTest.java line 55:
> 
>> 53:     public void lazyInitializedDefaultValue() {
>> 54:         // VM lazily sets the null-restricted non-flat field to zero default
>> 55:         assertTrue(new EmptyContainer() == EmptyContainer.default);
> 
> The `.default` syntax is translated to `aconst_init` which is going to be removed.
> May be use `ValueClass.zeroInstance(EmptyContainer.class)` instead.
> Applies to all `.default` usage in this file.

Ok.

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/960#discussion_r1417782983



More information about the valhalla-dev mailing list