[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v2]

[Roger Riggs]

On Wed, 22 Feb 2023 21:24:43 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Modify hotspot test for duplicate modules to check error message from the launcher
>>   instead of ExceptionInInitilizer.
>
> src/hotspot/share/runtime/arguments.cpp line 2221:
> 
>> 2219:       *(module_name + module_len) = '\0';
>> 2220:       // The path piece begins one past the module_equal sign
>> 2221:       add_patch_mod_prefix(module_name, module_equal + 1, false);
> 
> `patch_mod_javabase` seems unused here now. Not obvious that this flag is being tracked properly with the new changes.

Patch_mod_javabase is obsolete and is to be removed.
Each --patch-module is added to an array as the arguments are parsed.
After the arguments are parsed the array is checked to see if any modules have been patched.
That is sufficient for the decision to disable CDS.

-------------

PR: https://git.openjdk.org/valhalla/pull/816