[lworld] RFR: 8271959: [lworld] Convert Optional and VBS classes to value class [v4]
Roger Riggs
rriggs at openjdk.org
Thu Feb 23 20:45:38 UTC 2023
On Thu, 26 Jan 2023 20:59:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Restore disabling CDS if java.base is patched.
>
> There are two major ways you could approach this.
>
> 1. Define new top level targets for compiling the value classes and the subsequent jar files.
> 2. Modify make/CompileJavaModules.gmk to add a second optional compilation and jar file generation which would be part of the top level <module>-java target.
>
> You went with option 1. Both have pros and cons, so it kind of depends on what you expect to need to do, as a developer. Do you think you need the fine granular top level target support for selective building?
>
> Another aspect is that if you reuse the CompileJavaModules.gmk and run it again with a different outputdir, I think you will be rebuilding quite a lot of things unnecessarily. My understanding is that you only really need the value classes from the this second round of compilation.
@erikj79 When you have time can you look at the build changes. Thanks
-------------
PR: https://git.openjdk.org/valhalla/pull/816
More information about the valhalla-dev
mailing list