[lworld+vector] RFR: 8311610: [lworld+vector] Clean-up of vector allocation in class VectorSupport
Xiaohong Gong
xgong at openjdk.org
Fri Jul 7 08:18:13 UTC 2023
On Fri, 7 Jul 2023 08:09:58 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:
> > Hi @jatin-bhateja, could you please take a look at this PR? This is a cleanup to the vector allocation code in `vectorSupport.cpp`, which could also fix the jtreg regressions. Thanks a lot!
>
> Hi @XiaohongGong ,
>
> We can sweep out explicit handling related to vector/mask/shuffle during deoptimization, only two additional thing which may be needed are as follows :- 1/ Explicit larval flag setting on re-allocated vector payloads. 2/ Handling for non-flattened payloads under influence of InlineFieldMaxFlatSize.
>
> Best Regards, Jatin
Yes, I forgot the setting to larval flag. I will add this later. For 2, currently I don't know that the "final" flag influence to the flatten field. Since the payload field is final in Vector API, maybe it can always be flattened as you said in the maillist, right? Besides, I think the normal re-allocation in deoptimization.cpp should also consider the non-flattened fields as well, isn't it?
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/882#issuecomment-1624996693
More information about the valhalla-dev
mailing list