[lworld+vector] RFR: 8311610: [lworld+vector] Clean-up of vector allocation in class VectorSupport [v3]

Jatin Bhateja jbhateja at openjdk.org
Tue Jul 11 18:34:31 UTC 2023


On Tue, 11 Jul 2023 10:59:16 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix deoptimize issue for un-vectorized multifields
>
> src/hotspot/share/runtime/deoptimization.cpp line 1617:
> 
>> 1615:       ScopeValue* scope_field = sv->field_at(svIndex);
>> 1616:       StackValue* value = StackValue::create_stack_value(fr, reg_map, scope_field);
>> 1617:       offset += j * type2aelembytes(type);
> 
> Nice catch!!, It went in along with merge patch. Will run this through jtreg tests to ensure status quo or better validation status.
> 
> Best Regards,
> Jatin

Please also relax the condition on line # 1605 to just check for Location::vector

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/882#discussion_r1260126828



More information about the valhalla-dev mailing list