[lworld+vector] RFR: Merge lworld

Jatin Bhateja jbhateja at openjdk.org
Sun Jun 25 16:48:30 UTC 2023


On Sun, 25 Jun 2023 04:18:29 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

> Oh, I see the followed calling to `Deoptimization::reassign_fields_by_klass()`. An alternative way is to keep the vector assignment in `vectorSupport.cpp` like before, and other fields reassign in `deoptimization.cpp` like other normal objects. So that we doesn't need to modify too much during deoptimization. The only thing we have to do is passing the secondary fields to safepoint if not vectorized. WDYT?

I think is better to completely de-couple allocation and re-assignment so that we have clean interface, having one routine for allocation and re-initialization worked until now because VectorBox could never have a scalar / constant inputs, but this is now relaxed since InlineTypeNodes created during fallback implementation can have non-vector inputs, thus a split in initialization b/w allocation and existing re-assignment routines looks clumsy to me,

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/866#discussion_r1241236430



More information about the valhalla-dev mailing list