[lworld+vector] RFR: Merge lworld
Jatin Bhateja
jbhateja at openjdk.org
Mon Jun 26 07:43:33 UTC 2023
On Mon, 26 Jun 2023 07:24:21 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
> I'm fine with this patch except for some comments I added above and the jtreg crashes. Thanks!
Are you still facing JTREG crashes with -Xshare:off ?
I ran tests on AVX512 machine with default setting using above flags and most of the test points are passing as mentioned in PR description in all the *VectorTests.
===============================================
jdk/incubator/vector/Float128VectorTests.java
Total tests run: 2565, Passes: 2562, Failures: 3, Skips: 0
===============================================
Failures are of similar kind around masked vector operations and looks like related to de-optimization.
With UseAVX2 I am also able to reproduces similar issue in stand alone test
// CMD: java -XX:CompileThresholdScaling=0.1 -XX:+TraceDeoptimization -XX:-TieredCompilation -XX:UseAVX=2 -XX:+DeoptimizeALot -Xbatch --add-modules=jdk.incubator.vector -cp . deopt_shuffle_Byte512
import jdk.incubator.vector.*;
class deopt_shuffle_Byte512 {
public static void leaf(VectorShuffle<?> shuffle) {
throw new AssertionError(shuffle.toString());
}
public static int micro(int [] arr, int ctr) {
VectorShuffle<?> shuffle = VectorShuffle.fromArray(ByteVector.SPECIES_512, arr, 0);
if ((ctr % 2500) == 2000) {
leaf(shuffle);
}
return shuffle.laneSource(ctr & (ByteVector.SPECIES_512.length() - 1));
}
public static void main(String [] args) {
long res = 0;
int [] arr = new int[64];
for (int i = 0; i < arr.length; i++) {
arr[i] = 63 - i;
}
for (int i = 0; i < 100000; i++) {
res += micro(arr, i);
}
System.out.println("[res] " + res);
}
}
Exception in thread "main" java.lang.AssertionError: Shuffle[63, 62, 0, 61, 0, 0, 60, 0, 0, 0, 59, 0, 0, 0, 0, 58, 0, 0, 0, 0, 0, 57, 0, 0, 0, 0, 0, 0, 56, 0, 0, 0, 0, 0, 0, 0, 55, 0, 0, 0, 0, 0, 0, 0, 0, 54, 0, 0, 0, 0, 0, 0, 0, 0, 0, 53, 0, 0, 0, 0, 0, 0, 0, 0]
Exception in thread "main" java.lang.AssertionError: Shuffle[63, 62, 61, 60, 59, 58, 57, 56, 55, 54, 53, 52, 51, 50, 49, 48, 47, 46, 45, 44, 43, 42, 41, 40, 39, 38, 37, 36, 35, 34, 33, 32, 31, 30, 29, 28, 27, 26, 25, 24, 23, 22, 21, 20, 19, 18, 17, 16, 15, 14, 13, 12, 11, 10, 9, 8, 7, 6, 5, 4, 3, 2, 1, 0]
SHUFFLE_Byte512 FAIL
-------------
PR Comment: https://git.openjdk.org/valhalla/pull/866#issuecomment-1606892090
More information about the valhalla-dev
mailing list