RFR: 8310905: [lw5] addressing review comments on null restricted types

Vicente Romero vromero at openjdk.org
Wed Jun 28 04:18:32 UTC 2023


On Wed, 28 Jun 2023 04:11:15 GMT, Vicente Romero <vromero at openjdk.org> wrote:

> addressing some review comments related to PR [1]
> 
> [1] https://github.com/openjdk/valhalla/pull/872

src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java line 546:

> 544:             sb.append(hashCode());
> 545:         }
> 546:         if (isNullable()) {

strictly speaking currently we should only have the non-nullable case but I have provided the rest for completeness

-------------

PR Review Comment: https://git.openjdk.org/valhalla/pull/880#discussion_r1244644042



More information about the valhalla-dev mailing list