[lworld] RFR: 8303416: [lworld] Fix JVM crash at Unsafe_FinishPrivateBuffer [v2]

[Xiaohong Gong]

On Thu, 2 Mar 2023 10:01:41 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>>> I don't think this is correct, as it would overwrite the larval state of the default oop/buffer of that type. Right?
>> 
>> Yes, it would. And the larval state will be set back after calling "finishLarvalBuffer". I was thinking the whole progress happens in a single thread. But regarding to the default oop, changing larval state of it seems not right in multi-thread progress. So how about disgarding the GVN optimization of the `InlineTypeNode` if a private buffer is allocated and marked larval for it?
>
>> So how about disgarding the GVN optimization of the InlineTypeNode if a private buffer is allocated and marked larval for it?
> 
> Yes, I think that would make sense, although it's still an incomplete fix until JDK-8239003 is in.

Thanks for the review @TobiHartmann !

-------------

PR: https://git.openjdk.org/valhalla/pull/828